This repository was archived by the owner on May 28, 2021. It is now read-only.
Allow defining Resource Requirements per container in the ClusterSpec #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example: apiVersion: mysql.oracle.com/v1alpha1
kind: Cluster
metadata:
name: my-mysql-cluster
spec:
resources:
agent:
limits:
cpu: 500m
memory: 512Mi
requests:
cpu: 100m
memory: 128Mi
server:
limits:
cpu: 2
memory: 2Gi
requests:
cpu: 500m
memory: 1Gi
multiMaster: true
members: 3
... |
KashifSaadat
force-pushed
the
add-resource-requirements
branch
from
cfc7df0 to
946e2ed
Compare
Signed-off-by: Kashif Saadat <kashifsaadat@gmail.com>
KashifSaadat
force-pushed
the
add-resource-requirements
branch
from
946e2ed to
bdcfffb
Compare
|
Thanks! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If default resource limits are defined too low for a namespace, the mysql-server container may fail to bootstrap / run successfully and hit
OOMKillederrors.This PR extends the MySQL ClusterSpec to allow defining custom resource requirements per container (server and agent), which are passed onto the StatefulSet definition.